-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix lsp config reload #9415
Merged
Merged
fix lsp config reload #9415
+89
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirawi
added
C-bug
Category: This is a bug
A-helix-term
Area: Helix term improvements
labels
Jan 24, 2024
kirawi
reviewed
Jan 24, 2024
kirawi
approved these changes
Jan 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see anything obviously incorrect here; it's pretty straightforward.
the-mikedavis
previously approved these changes
Feb 10, 2024
pascalkuthe
previously approved these changes
Feb 12, 2024
There are some small conflicts with some other PRs that were merged once those are resolved this lgtm. |
`syn_loader` was replaced rather than interior value being replace, old value was still being referenced and not updated after `:config-refresh`. By using `ArcSwap` like for `config`, each `.load()` call will return the most updated value.
kyfanc
dismissed stale reviews from pascalkuthe and the-mikedavis
via
February 12, 2024 04:47
6c03f77
kyfanc
force-pushed
the
fix-lsp-config-reload
branch
from
February 12, 2024 04:47
8f051e6
to
6c03f77
Compare
the-mikedavis
approved these changes
Feb 12, 2024
pascalkuthe
approved these changes
Feb 13, 2024
cosmikwolf
pushed a commit
to cosmikwolf/helix
that referenced
this pull request
Feb 26, 2024
`syn_loader` was replaced rather than interior value being replace, old value was still being referenced and not updated after `:config-refresh`. By using `ArcSwap` like for `config`, each `.load()` call will return the most updated value. Co-authored-by: kyfan <kyfan@email>
postsolar
pushed a commit
to postsolar/helix
that referenced
this pull request
Apr 4, 2024
`syn_loader` was replaced rather than interior value being replace, old value was still being referenced and not updated after `:config-refresh`. By using `ArcSwap` like for `config`, each `.load()` call will return the most updated value. Co-authored-by: kyfan <kyfan@email>
mtoohey31
pushed a commit
to mtoohey31/helix
that referenced
this pull request
Jun 2, 2024
`syn_loader` was replaced rather than interior value being replace, old value was still being referenced and not updated after `:config-refresh`. By using `ArcSwap` like for `config`, each `.load()` call will return the most updated value. Co-authored-by: kyfan <kyfan@email>
Vulpesx
pushed a commit
to Vulpesx/helix
that referenced
this pull request
Jun 7, 2024
`syn_loader` was replaced rather than interior value being replace, old value was still being referenced and not updated after `:config-refresh`. By using `ArcSwap` like for `config`, each `.load()` call will return the most updated value. Co-authored-by: kyfan <kyfan@email>
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
`syn_loader` was replaced rather than interior value being replace, old value was still being referenced and not updated after `:config-refresh`. By using `ArcSwap` like for `config`, each `.load()` call will return the most updated value. Co-authored-by: kyfan <kyfan@email>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-helix-term
Area: Helix term improvements
C-bug
Category: This is a bug
S-waiting-on-review
Status: Awaiting review from a maintainer.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix #9398
syn_loader
was replaced rather than interior value being replace,old value was still being referenced and not updated after
:config-refresh
.By using
ArcSwap
similarly toconfig
, each.load()
call will return the most updated value.Testing Steps
rust-analyzer
inlanguages.toml
.:config-reload
and:lsp-restart
PS. This is my first PR, please let me know if there is anything I missed/ overlooked.